-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favicon gets "not found" error on non-homepage pages #507
Comments
Hi sir, My name is Natnael Yohanes 3rd Year Software engineering Student at AAiT(Ethiopia). I am a Full-stack developer specifically MERN stack and came to SugarLabs to contribute with the skills I have. I have checked line 14 and if the logoID is undefined or corresponds to an invalid image, the favicon will fail to load. |
I'm not certain that this ever effects the production site. But I don't understand why we get the error when running it locally. |
@pikurasa, can I work on this issue? |
Should probably also change the defaultIcon href sooner, using script in index.html, as the way it is happening at the moment in js/main.js on Firefox collides in time with the loading of the default, resulting in NS_BINDING_ABORTED in Console and Network view of Developer Tools. |
I’ve submitted a PR (#617) to fix the "favicon not found" error on non-homepage pages, particularly on Firefox. The issue was caused by an incorrect favicon path, and the fix ensures consistent favicon display across all pages. |
Thanks. You don't need to tell us you've made a pull request for the issue, as GitHub automatically tells us. |
Reproduced on master 66f7078. As indicated earlier, the problem continues to be collision between the asynchronous threads; the execution of the js/main.js vs the automatic loading of the icon by the pre-rendering of the index.html. Perhaps the defer in the call to js/main.js should be reconsidered? |
…olute path to relative. Fixes sugarlabs#507 - Fixed "favicon not found" error on non-homepage pages, particularly in Firefox. - Problem traced to incorrect favicon path introduced in commit #58177ea. - Updated path from absolute to relative to resolve the issue. - Ensures favicons load correctly across all pages.
I've looked at our logic on /js/main.js, and I don't understand why it would be happening. It looks to me like
https://www.sugarlabs.org/assets/favicon_
is hardcoded in (Line 14).That said, it's not clear to me whether this has any impact on the live site. If not, then perhaps we add a comment noting as much somewhere in the code.
The text was updated successfully, but these errors were encountered: