-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4195 (Added dark mode feature) #4207
base: master
Are you sure you want to change the base?
Conversation
Here everything is working good the images are : Only limitation is in image 2: |
Why limitation was ocured:
a) CSS Approach Failed:
b) JavaScript Direct Modification Failed:
4.Correct Approach Would Be:
This explains why simple CSS or JavaScript changes weren't sufficient - we need to modify the core canvas initialization process to properly implement dark mode. |
@walterbender i dont think it is the better version as canvas and many things just seems to be uneven i guess |
great effort, but I think what adding dark mode must do is basically adding it optionally as a toggle. and the whole background should be dark as well. please join the matrix channel, you will know more about plans around this. the community is still figuring it out about the implementation. |
@retrogtx sir How can I join matrix channel |
I'm 20 years old, contributor like you only Here is the channel: https://app.element.io/#/room/#sugar:matrix.org |
name: Pull Request
about: Submit changes to the project for review and inclusion
Description
This PR implements dark mode support for Music Blocks, integrating with Sugar's activity system to provide consistent dark mode behavior. The implementation focuses on making the workspace and canvas background adapt to Sugar's color settings
Related Issue
This PR fixes #4195 issue.
This PR fixes #
Changes Made
SugarLabs/musicblocks/css/dark-mode/workspace.css
SugarLabs/musicblocks/js/turtles.js
SugarLabs/musicblocks/js/loader.js
SugarLabs/musicblocks/activity/activity.info
Testing Performed
- Initial load
- Sugar color changes
- Activity restart
Checklist
[✅] I have tested these changes locally and they work as expected
[✅] I have followed Sugar activity guidelines for dark mode
[✅] I have maintained compatibility with existing functionality
[✅] I have kept the changes minimal and focused
[✅] I have tested the changes in both light and dark modes
Additional Notes for Reviewers
Current limitations:
The implementation follows SugarLabs's activity system patterns and maintains the existing codebase structure while adding dark mode support.
Thank you for contributing to our project! We appreciate your help in improving it.
📚 See contributing instructions.
🙋🏾🙋🏼 Questions: Community Matrix Server.