@walterbender Sir, I think it will definitely help users. Please check it.

I like the basic idea (we have something similiar in the Python version of Turtle Blocks). But I am loath to add yet another button to the toolbar. Maybe this is the default behavior of the restore button? @pikurasa what do you think?

I like the basic idea (we have something similiar in the Python version of Turtle Blocks). But I am loath to add yet another button to the toolbar. Maybe this is the default behavior of the restore button? @pikurasa what do you think?

Sir which should be the default behavior previous functionality or the functionality in this PR ?

@walterbender @pikurasa Sir can we add this feature to the current Restore button so we don't need to create a new button in toolbar again.

Let's wait to hear from @pikurasa

I think that the implementation in the python Turtle Art is better than this, and I think, if we do it at all, we should do it more similar to that.

I think the design should be:

• There is a single trash button.
• When you click the trash button, you see all the items that are in the trash bin, like you can see items in a palette.
• Unlike the palette, you get some special buttons, such as "restore last" and "restore all". These buttons should probably be sticky at the top of the palette.
• "Restore last" behaves the way our current "Restore" works, and "restore all" restores all the items in the trash.
• (For now, we can just implement "restore last". We can implement "restore all" later. And we can discuss whether or not we want to be able to "empty trash" as you can with Turtle Art.)

Okay I am working on it.

@walterbender @pikurasa Sir, I have changed it like this. If any changes required please let me know

@walterbender @pikurasa Sir, I have changed it like this. If any changes required please let me know
Screen.Recording.2024-12-31.004222.mp4

I like that design, in general.

The blocks showing as black and white; I can't decide on whether that's a good thing or not. It may be nice that they don't render in color, as that kind of indicates that they are " currently trashed".

Looks good. I think the only change would be to put the buttons all the way to the top so the blocks don't appear above the buttons.

Now this looks like

If I understand it correctly, the button on the piemenu pops one item off the trash stack, while the toolbar button displays the trash list? I think that is a good decision.

@walterbender Sir I have changed according to you said. Please review

For some reason, the button label is not appearing.

@walterbender Sir I have tested in my local machine and different browsers also it works as expected.

I will try again. I am using the latest Firefox on Fedora.

I don't see anything in the logs.

Sir I have tested in a different machine with latest firefox but it works...I am trying to find

I kept it buttons for now if we need icons i will change it later on.

@walterbender @pikurasa Sir, what should we kept it button or icon ?

I would prefer icons with hover help as it is consistent with the rest of the interface,

I would prefer icons with hover help as it is consistent with the rest of the interface,

Which icon should I use ?

I was thinking of something like these...

@walterbender Sir I am unable to find these icons which you sent. But I made the changes with these icons

+1 to using icons.
I think we may want to generate our own icons though... but we can do that in a separate PR.

But the icons should have some hover help strings.

But the icons should have some hover help strings.

Yes Sir I am trying to do that. Can you help me to find out the related code for it ?

There are lots of examples of tooltips in js/toolbar.js

@walterbender Sir now icons have hover help strings like

Yes Sir I have changed it. Please check.

I was doing one more round of testing and bumped into a problem: the restore last item button doesn't seem to restore the last item if there is only one item in the trash.

Steps to reproduce:

1. delete something; there should be one item in the trash.
2. delete something else; there should be two items in the trash.
3. restore one item (either by clicking on it or using the restore last item button); there should be one item in the trash.
4. try using the restore last item button.
5. observe that nothing is restored and there is still one item in the trash.

Both the restore all items button and clicking on the item will restore the last item.

I was doing one more round of testing and bumped into a problem: the restore last item button doesn't seem to restore the last item if there is only one item in the trash.

Steps to reproduce:

1. delete something; there should be one item in the trash.
2. delete something else; there should be two items in the trash.
3. restore one item (either by clicking on it or using the restore last item button); there should be one item in the trash.
4. try using the restore last item button.
5. observe that nothing is restored and there is still one item in the trash.

Both the restore all items button and clicking on the item will restore the last item.

Sir I reproduced this so many times. But it works properly like it

I was using Firefox. Maybe something browser related? But it seems unlikely.

I was using Firefox. Maybe something browser related? But it seems unlikely.

I recorded this video in Firefox. Before that i used Chrome and Brave. Sir could you please check it once again ?

I think I figured out the specifics of when it breaks.
If the last block to be restored is a Start block, the restore last item doesn't seem to work. Otherwise it seems to work. Can you please test that condition?

I think I figured out the specifics of when it breaks. If the last block to be restored is a Start block, the restore last item doesn't seem to work. Otherwise it seems to work. Can you please test that condition?

@walterbender Yes Sir. In this case Restore last item was not working. But after this change it is working as expected.

Okay. I added spaces around operators.

@walterbender Sir there any changes required ?

You tested:
this._restoreTrashById(this.blocks.trashStacks[this.blocks.trashStacks.length - 1]);

I don't know why that couldn't replace the for loop.

You tested: this._restoreTrashById(this.blocks.trashStacks[this.blocks.trashStacks.length - 1]);

I don't know why that couldn't replace the for loop.

Sir I replace the loop with this line now it also works for start block in every condition. Could you please check it once ?