Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear button is not in style #30

Closed
quozl opened this issue Dec 30, 2024 · 8 comments
Closed

Clear button is not in style #30

quozl opened this issue Dec 30, 2024 · 8 comments

Comments

@quozl
Copy link
Contributor

quozl commented Dec 30, 2024

Clear button added recently is not the right icon as defined in sugar-toolkit-gtk3 for this purpose.

@CWAbhi
Copy link
Contributor

CWAbhi commented Dec 31, 2024

@quozl can you please explain the issue little more.

@anya-xcode
Copy link

@quozl please assign me, i want to work on this issue!

@quozl
Copy link
Contributor Author

quozl commented Dec 31, 2024

My mistake, sorry. Use edit-clear.svg from the sugar-artwork repository.

I see that Sugar activities TamTam, Paint, Memorize, Gears, and Abacus have slight variants of the icon, but they all look the same to me.

I see that Sugarizer activities Abacus, Fototoon, Paint, Gears, Memorize, Calculate and Stopwatch also have copies of the icon.

For GTK activities, we can rely on sugar-artwork being available. I'm not sure, but I think for HTML/JavaScript activities like this one we have to include each icon used in the bundle.

  • replace the icon,
  • prepare an activity bundle (the .xo file),
  • install in Sugar,
  • demonstrate test in Sugar.

@CWAbhi
Copy link
Contributor

CWAbhi commented Jan 1, 2025

@anya-xcode i am working in this issue so if you don't mind can you look up for another issue.

@CWAbhi
Copy link
Contributor

CWAbhi commented Jan 1, 2025

@quozl i have understood what you want and i will raise a PR fixing all this

@quozl
Copy link
Contributor Author

quozl commented Jan 1, 2025

Just a reminder that at Sugar Labs we do not assign issues, and we don't mind if more than one person works on the same issue. It is at the time of competing pull requests that we reach consensus, once all are reviewed. We also don't mind if one person uses the commits of another as the basis for their work. That's the nature of our open source licensing.

We also expect each of you to review pull requests as well. You can review each other's.

@CWAbhi
Copy link
Contributor

CWAbhi commented Jan 1, 2025

okay sure

@CWAbhi CWAbhi mentioned this issue Jan 1, 2025
@CWAbhi
Copy link
Contributor

CWAbhi commented Jan 1, 2025

#31 check the PR @quozl the first two edits are done . Please review it and if they are good to go merge it.

@quozl quozl closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants