forked from microsoft/typescript-styled-plugin
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e Tests fail #9
Comments
I'm looking into a bug and found that the e2e tests work for me, perhaps worth trying again now? |
Yes I fixed it the other day so it’s fine now, this can be closed. Out of interest what big are you looking into? |
@jasonwilliams this bug here: styled-components/vscode-styled-components#440 I'll raise an issue here with a failing test case edit: raised: #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey @mjbvz it looks like e2e tests now fail since either the TypeScript update or VSCode update.
https://github.com/styled-components/typescript-styled-plugin/actions/runs/4601280928/jobs/8128959986#step:7:12
I reverted both TypeScript and typescript-template-language-service-decorator and it still fails, so it maybe an update in vscode itself.
I don't think this test suite has changed since you last wrote it
Do you know what this could be?
Example of a real request/response using current version
The below is adding
background-color:
and hitting ctrl + enter with"typescript.tsserver.log": "verbose"
enabled in the settings.We can see that its working fine, when ran for real.
However, looking at the e2e test, we see a different story.
There's been no changes made to these tests since its been forked, so I guess something upstream has caused these to stop working.
The text was updated successfully, but these errors were encountered: