Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build development branch #40

Open
jwillmer opened this issue Sep 9, 2020 · 6 comments
Open

Can't build development branch #40

jwillmer opened this issue Sep 9, 2020 · 6 comments

Comments

@jwillmer
Copy link

jwillmer commented Sep 9, 2020

I like to get a docker image with the changes you merged into dev branch. But building the image returns the following:

image

@stripydog
Copy link
Owner

I believe the issue is that the Dutch file must have been done in UTF-16 on windows. I'm away on the boat at the moment, back this weekend. Can you try "dos2unix nl", then retry the install and see if that fixes it? If you can confirm that works on your system I'll make that change and push it when I get a chance

stripydog added a commit that referenced this issue Sep 9, 2020
@stripydog
Copy link
Owner

Try the "fix-40" branch: it's just develop with the above conversion. If you confirm it fixes the problem I'll merge to develop

@jwillmer
Copy link
Author

jwillmer commented Sep 9, 2020

If you merge #41 then a docker image will auto build on each commit to dev branch. This way you will notice this immediately - and I don't need to test ;)

@stripydog
Copy link
Owner

I don’t merge anything to develop without testing in another branch first and my copy of gencat wasn’t throwing the same errors, so would appreciate if you could confirm this now works for you

@stripydog
Copy link
Owner

I tested myself even though my copies of gencat weren't throwing the same errors: seemed ok so I've merged it. Can you confirm this works OK now?

@jwillmer
Copy link
Author

Same error. Steps to reproduce:

  • checkout dev branch
  • execute docker build .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants