Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ban/softban events not being registered, add to tracker #339

Open
emmiegit opened this issue Apr 30, 2020 · 0 comments
Open

Fix ban/softban events not being registered, add to tracker #339

emmiegit opened this issue Apr 30, 2020 · 0 comments
Labels
bug enhancement

Comments

@emmiegit
Copy link
Collaborator

emmiegit commented Apr 30, 2020 •
edited
Loading

This cleans up the following TODOs:

futaba/futaba/cogs/moderation/core.py

Line 372 in d1109c4

# TODO add to tracker and add handler to journal event to prevent ban/softban event

futaba/futaba/cogs/moderation/core.py

Line 406 in d1109c4

# TODO add tracker unban event and move this to journal/impl/moderation.py

This is intended to address the longstanding issue where bans are not properly recorded as moderation journal events, due to the discord-level conflation of bans/softbans.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emmiegit