Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary methods from TopicOperatorUtil class #10916

Open
scholzj opened this issue Dec 5, 2024 · 1 comment · May be fixed by #10918
Open

Remove unnecessary methods from TopicOperatorUtil class #10916

scholzj opened this issue Dec 5, 2024 · 1 comment · May be fixed by #10918
Labels
topic operator

Comments

@scholzj
Copy link
Member

scholzj commented Dec 5, 2024

The TopicOperatorUtil class has a bunch of methods that really just forward the call to another classes. For example createKafkaAdminClient or createCruiseControlClient. We should aim to remove them and make the call directly simialrly to how it was done in #10901 to the Kubernetes Client method.

This issue is based on the this discussion: #10901 (comment) with @fvaleri.
@scholzj scholzj mentioned this issue Dec 5, 2024
Merged
2 tasks
fvaleri added a commit to fvaleri/strimzi-kafka-operator that referenced this issue Dec 6, 2024
@fvaleri
Remove unnecessary methods from TopicOperatorUtil class
b8daf92 
This patch removes unnecessary methods from TopicOperatorUtil class.

Closes strimzi#10916.

Signed-off-by: Federico Valeri <[email protected]>
@fvaleri fvaleri linked a pull request Dec 6, 2024 that will close this issue
Open
2 tasks
@ppatierno
Copy link
Member

Triaged on 12/12/2024: Fede is working on this issue and opened a PR. We'll keep this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary methods from TopicOperatorUtil class fvaleri/strimzi-kafka-operator
2 participants
@scholzj @ppatierno