Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand FFI functionality #919

Closed
5 of 9 tasks
plebhash opened this issue May 21, 2024 · 10 comments
Closed
5 of 9 tasks

expand FFI functionality #919

plebhash opened this issue May 21, 2024 · 10 comments
Labels
backlog Not necessary, but worth tracking ffi FFI related logic firmware

Comments

@plebhash
Copy link
Collaborator

plebhash commented May 21, 2024

As discussed here, for historical reasons, the FFIs were started with the intention to be imported into Bitcoin Core (TP).

So FFI functionality is currently limited to:

  • protocols/v2/codec-sv2
  • protocols/v2/const-sv2
  • protocols/v2/binary-sv2
  • protocols/v2/subprotocols/common-messages
  • protocols/v2/subprotocols/template-distribution-sv2

In order to allow firmware integrations (e.g.: skot/ESP-Miner#168), this functionality needs to be expanded with:

  • protocols/v2/framing-sv2
  • protocols/v2/noise-sv2
  • protocols/v2/subprotocols/job-declaration
  • protocols/v2/subprotocols/mining
@plebhash plebhash added backlog Not necessary, but worth tracking ffi FFI related logic firmware labels May 21, 2024
@plebhash

This comment was marked as resolved.

@Fi3

This comment was marked as resolved.

@Fi3

This comment was marked as resolved.

@plebhash

This comment was marked as resolved.

@Fi3

This comment was marked as resolved.

@plebhash

This comment was marked as resolved.

@Fi3

This comment was marked as resolved.

@plebhash

This comment was marked as resolved.

@plebhash
Copy link
Collaborator Author

CI problems discussed above were solved via #1172

hiding the discussion to avoid confusion

the core goal of this issue remains: expand FFI functionality to all protocols crates

@plebhash
Copy link
Collaborator Author

plebhash commented Jan 29, 2025

since opening this issue, I changed my mind on this topic

as far as we know, FFIs are not being actively used for any project in the community

the argument for firmware (e.g.: skot/ESP-Miner#168 + https://github.com/plebhash/cgminer-sv2) no longer seems like a meaningful motivation to me, given that in 2025 pure-Rust firmware is perfectly doable (e.g.: https://github.com/bitaxeorg/esp-miner-rs)

expanding FFI functionality would consist of a substantial engineering effort, and we don't really seem to have any real motivation for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Not necessary, but worth tracking ffi FFI related logic firmware
Projects
Status: Done ✅
Development

No branches or pull requests

2 participants