onboarding page #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ffrryy can you upload the screenshot or a video sample of your working result in your PR description please, thanks |
| # - images/a_dot_ham.jpeg | ||
| assets: | ||
| - assets/images/ | ||
| - assets/icons/ |
There was a problem hiding this comment.
seems like the icon folder still not existing on the project. You can remove this line
| @@ -12,7 +12,7 @@ class MyApp extends StatelessWidget { | |||
| Widget build(BuildContext context) { | |||
| return const MaterialApp( | |||
| title: 'Food App', | |||
| initialRoute: AppRoutes.mainPage, | |||
| initialRoute: AppRoutes.onBording, | |||
There was a problem hiding this comment.
you can change onBording with onBoarding. We should use the proper name for naming the variable
| const Spacer(flex: 3), | ||
| BaseButton( | ||
| buttonColor: AppColor.mainColor, | ||
| child: Container( |
There was a problem hiding this comment.
We can use SizedBox for whitespace instead of Container
| import 'package:food_app/utils/app_size_config.dart'; | ||
|
|
||
| class OnBordingScreen extends StatelessWidget { | ||
| final String onBording; |
There was a problem hiding this comment.
you can remove this, also the required below. Don't forget to check the app_router.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add onboarding page.
