Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flash_get_ldf() and flash_get_fitted_values() are not exported. #95

Open
dcgerard opened this issue Jun 19, 2019 · 2 comments
Open

flash_get_ldf() and flash_get_fitted_values() are not exported. #95

dcgerard opened this issue Jun 19, 2019 · 2 comments

Comments

@dcgerard
Copy link
Member

The documentation in flash() says

Use flash_get_ldf to access standardized loadings and factors; use flash_get_fitted_values to access fitted LF'.

But flash_get_ldf() and flash_get_fitted_values() are not exported functions. What is the recommended way to access output?

@stephens999
Copy link
Contributor

this was an oversight - thanks!
I just pushed something that should fix this.

@willwerscheid
Copy link
Member

willwerscheid commented Jun 22, 2019

ldf and fitted_values are returned directly -- getter functions aren't really necessary. (fl <- flash(...); fl$fitted_values; fl$ldf). Documentation should be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants