Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price struct integer overflow #228

Open
cuongph87 opened this issue Jan 16, 2025 · 0 comments
Open

Price struct integer overflow #228

cuongph87 opened this issue Jan 16, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@cuongph87
Copy link

What version are you using?

Version 22.0.0. But it shouldn't matter.

What did you do?

While the XDR definition specifies int32, the actual Stellar network allows for prices with numerators and denominators exceeding the int32 range. This causes parsing failures when attempting to process such transactions.

A real-world example can be found in this trade:
https://horizon.stellar.org/trades?cursor=237504432974213121-0&limit=1

What did you expect to see?

Larger values observed in the network should be handled properly.

@cuongph87 cuongph87 added the bug Something isn't working label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant