From 66de48c8e4e68d8be66d0110b7d2b32753761721 Mon Sep 17 00:00:00 2001 From: Elizabeth Engelman <4752801+elizabethengelman@users.noreply.github.com> Date: Thu, 19 Dec 2024 12:47:30 -0500 Subject: [PATCH 1/2] Log tx signing before submitting in install --- cmd/soroban-cli/src/commands/contract/upload.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/cmd/soroban-cli/src/commands/contract/upload.rs b/cmd/soroban-cli/src/commands/contract/upload.rs index 0a9ec856d..a03d3c6b3 100644 --- a/cmd/soroban-cli/src/commands/contract/upload.rs +++ b/cmd/soroban-cli/src/commands/contract/upload.rs @@ -192,11 +192,10 @@ impl NetworkRunnable for Cmd { return Ok(TxnResult::Txn(txn)); } - print.globeln("Submitting install transaction…"); + let signed_txn = &self.config.sign_with_local_key(*txn).await?; - let txn_resp = client - .send_transaction_polling(&self.config.sign_with_local_key(*txn).await?) - .await?; + print.globeln("Submitting install transaction…"); + let txn_resp = client.send_transaction_polling(signed_txn).await?; if args.map_or(true, |a| !a.no_cache) { data::write(txn_resp.clone().try_into().unwrap(), &network.rpc_uri()?)?; From a97a57a1cc060d9aa7d7f66832a54de7b088cb78 Mon Sep 17 00:00:00 2001 From: Elizabeth Engelman <4752801+elizabethengelman@users.noreply.github.com> Date: Thu, 19 Dec 2024 12:48:01 -0500 Subject: [PATCH 2/2] Log tx signing before submitting in deploy --- cmd/soroban-cli/src/commands/contract/deploy/wasm.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cmd/soroban-cli/src/commands/contract/deploy/wasm.rs b/cmd/soroban-cli/src/commands/contract/deploy/wasm.rs index 58ccac7f5..f793d61bd 100644 --- a/cmd/soroban-cli/src/commands/contract/deploy/wasm.rs +++ b/cmd/soroban-cli/src/commands/contract/deploy/wasm.rs @@ -288,11 +288,12 @@ impl NetworkRunnable for Cmd { return Ok(TxnResult::Txn(txn)); } - print.globeln("Submitting deploy transaction…"); print.log_transaction(&txn, &network, true)?; + let signed_txn = &config.sign_with_local_key(*txn).await?; + print.globeln("Submitting deploy transaction…"); let get_txn_resp = client - .send_transaction_polling(&config.sign_with_local_key(*txn).await?) + .send_transaction_polling(signed_txn) .await? .try_into()?;