Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Onboarding] Refactor LoginScreen to make store independent and part of the OnboardingFlow #17160

Closed
micieslak opened this issue Jan 29, 2025 · 0 comments · Fixed by #17161
Closed

[Onboarding] Refactor LoginScreen to make store independent and part of the OnboardingFlow #17160

micieslak opened this issue Jan 29, 2025 · 0 comments · Fixed by #17161
Assignees
@micieslak
Labels
bug Something isn't working core-team
Milestone
2.33.0 Beta

Comments

@micieslak
Copy link
Member

Description

The idea is to make the LoginScreen simpler, without ui-unrelated logc and wiring with the store done the layer above, OnboardingLayout.
@micieslak micieslak added the bug Something isn't working label Jan 29, 2025
@micieslak micieslak self-assigned this Jan 29, 2025
@micieslak micieslak moved this to In Progress in Status Desktop/Mobile Board Jan 29, 2025
micieslak added a commit that referenced this issue Jan 29, 2025
@micieslak
Onboarding: LoginScreen location adjusted
6914cc7 
- LoginScreen SB page simplified
- OnboardingLayoutPage - settings introduced for handier testing
- LoginScreen moved from OnboardingLayout to OnboardingFlow, making first flow's page bound to model content (instead of relying on check during initialization)
- UnblockWithPukFlow removed from OnboardingLayout (now it's used only in OnboardingFlow)
- Login error/success processing extracted from LoginScreen to OnboardingLayout
- small bug fixed in Utils::objectTypeName

Closes: #17160
@micieslak micieslak mentioned this issue Jan 29, 2025
Merged
1 task
@iurimatias iurimatias added this to the 2.33.0 Beta milestone Jan 29, 2025
micieslak added a commit that referenced this issue Jan 30, 2025
@micieslak
Onboarding: LoginScreen location adjusted
bba0c92 
- LoginScreen SB page simplified
- OnboardingLayoutPage - settings introduced for handier testing
- LoginScreen moved from OnboardingLayout to OnboardingFlow, making first flow's page bound to model content (instead of relying on check during initialization)
- UnblockWithPukFlow removed from OnboardingLayout (now it's used only in OnboardingFlow)
- Login error/success processing extracted from LoginScreen to OnboardingLayout
- small bug fixed in Utils::objectTypeName

Closes: #17160
micieslak added a commit that referenced this issue Jan 30, 2025
@micieslak
Onboarding: LoginScreen location adjusted
b27095a 
- LoginScreen SB page simplified
- OnboardingLayoutPage - settings introduced for handier testing
- LoginScreen moved from OnboardingLayout to OnboardingFlow, making first flow's page bound to model content (instead of relying on check during initialization)
- UnblockWithPukFlow removed from OnboardingLayout (now it's used only in OnboardingFlow)
- Login error/success processing extracted from LoginScreen to OnboardingLayout
- small bug fixed in Utils::objectTypeName

Closes: #17160
@micieslak micieslak moved this from In Progress to Code Review in Status Desktop/Mobile Board Jan 30, 2025
micieslak added a commit that referenced this issue Jan 30, 2025
@micieslak
Onboarding: LoginScreen location adjusted
b3b8b38 
- LoginScreen SB page simplified
- OnboardingLayoutPage - settings introduced for handier testing
- LoginScreen moved from OnboardingLayout to OnboardingFlow, making first flow's page bound to model content (instead of relying on check during initialization)
- UnblockWithPukFlow removed from OnboardingLayout (now it's used only in OnboardingFlow)
- Login error/success processing extracted from LoginScreen to OnboardingLayout
- small bug fixed in Utils::objectTypeName

Closes: #17160
micieslak added a commit that referenced this issue Jan 31, 2025
@micieslak
Onboarding: LoginScreen location adjusted
944568e 
- LoginScreen SB page simplified
- OnboardingLayoutPage - settings introduced for handier testing
- LoginScreen moved from OnboardingLayout to OnboardingFlow, making first flow's page bound to model content (instead of relying on check during initialization)
- UnblockWithPukFlow removed from OnboardingLayout (now it's used only in OnboardingFlow)
- Login error/success processing extracted from LoginScreen to OnboardingLayout
- small bug fixed in Utils::objectTypeName

Closes: #17160
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micieslak micieslak

Labels
bug Something isn't working core-team
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.33.0 Beta
Development

Successfully merging a pull request may close this issue.

Onboarding: LoginScreen location adjusted status-im/status-desktop
2 participants
@iurimatias @micieslak