EPIC: Simplified Send Transaction

[Khushboo-dev-cpp]

Description

As a first step in stabilising and having a bug free send, the team has decided to go ahead with single network send as a version 1.

This epic covers all the changes that need to be done in send as finalised by the team.

Designs: https://www.figma.com/design/FkFClTCYKf83RJWoifWgoX/Wallet-v2?node-id=25182-169274&t=Ech2sOd4zCGhGFzC-4
User Stories: https://www.notion.so/Making-transactions-Send-Bridge-Simplified-1128f96fb65c80d78d6ed0788776e98f?pvs=4

SubComponents Rework:

• Adapt Token Selector #16702
• Adapt AmountToSend #16703
• Adapt Account Selector #16705
• Using Max Amount for amount to send #15709
• Adapt Fees component #16706
• New Error component #16707
• Adapt Sign Modal #16708
• New Send Footer #16918
• Make footer and header opaque with blurring effect
• Discuss way of working for input/output properties in send modal #16999

Main Tasks:

• Send Modal Invocations #16710
• Adapt invocations to New Simple Send Modal #17023
• Token Selection #16820
• Recipient selection #16916
• Entering asset value #16903
• Changing network #16878
• Changing account #16835
• Using Max control
• Switching Base fee to fiat #16913
• Fees calculation
• Signing transaction (Asset + Collectible) #17060
• Error states #17000
• Toasts
• Dialog sizing #16836
• Connect to backend code #16919

Miscellaneous TBD:

• Add option to not show Popular section in TokenSelectorViewAdaptor.qml #17148
• Add back Metric events #17112
• User AccountSelectorAdaptor defined here feat(@desktop/wallet): Move the Account Selector logic to show selected token balance on a specific network to a dedicated WalletAccountsSelectorAdaptor #16834
• Remove old SendModal
• Remove logic from nim code
• user new router formats only and remove the old ones
• Network Selector interactive mode needs some design and rework
• Integrate Recipient View into the sign modal #17114
• Implement new error state #17141
• Write Unit Tests #17123
• Update simple send modal recipient view height #17132

[micieslak]

I left some comments in subtasks.

Moreover I noticed one big thing necessary to do along with the planned simplifications. It's consequence of design changes regarding scrolling:

It means that top level layout of SendModal needs to be rethought and organised from scratch with that scrolling behavior in mind. Everything above the list should be put into ListView header probably.

[Khushboo-dev-cpp]

I left some comments in subtasks.

Moreover I noticed one big thing necessary to do along with the planned simplifications. It's consequence of design changes regarding scrolling:

It means that top level layout of SendModal needs to be rethought and organised from scratch with that scrolling behavior in mind. Everything above the list should be put into ListView header probably.

@micieslak this behaviour only applies when screen size < 720 px.

But your suggestion for moving everything above the list to listview header makes sense. We could play with sticky property based on screen height.

[anastasiyaig]

@alaibe @Khushboo-dev-cpp I moved that to 2.33 milestone as we discussed

[virginiabalducci]

Hi @Khushboo-dev-cpp

I've started testing and I'll post issues or questions to validate whether they are issues. I'll edit this comment as I go

• ### Issue 1

There is a padding or margin issue in the 'Assets' tab of the 'Select token' drop-down

[Khushboo]: Should be fixed in latest by https://github.com/status-im/status-desktop/pull/17133

• ### Issue 2

The Network drop-down should be disabled when the user has selected a collectible and has opened the send modal

send.option.from.the.collectibles.details.-.network.should.be.disabled.mov

Given the user is in the All Accounts view
When the user chooses and clicks on a collectible (ERC1155 or ERC721)
When the user clicks the Send option from the footer in Collectibles detail
Then the Send modal is launched with the Account that hodls the collectible
Then the Send modal has the chain on which the collectible resides selected (dropdown disabled)
Then the Send modal has the selected collectible preselected
Then the Send modal has no preselected recipient
Then the Amount input is removed

[Khushboo]: I didnt implement this on purpose and have handled , that if the user switches network and collectible is not on that chainId the TokenSelector is reset. @benjthayer do you think its a good idea to not keep it disabled?

• ### Issue 3

When the send modal is launched from a saved address, the name of the saved address is not displaying in the Send modal

saved.address.name.is.not.showing.mov

Actual result:

Expected result:

• ### Issue 4

'To' element tabs 'Recent', 'Saved' and 'My accounts' show the same items.
It seems all tabs show the address list from the 'Recent' tab.
'Saved' tab should only show 1 account for this user
'My accounts' tab should only show the user's accounts

This console error triggers when clicking the tabs:

WRN 2025-01-29 20:51:09.644Z qt warning topics="qt" tid=18086490 text="TypeError: Cannot assign to read-only property \"selectedRecipientType\"" file=qrc:/app/AppLayouts/Wallet/panels/RecipientSelectorPanel.qml:159 category=default

Screen.Recording.2025-01-29.at.5.50.58.PM.mov

[Khushboo]: Ive fixed this here https://github.com/status-im/status-desktop/pull/17150/files#

• ### Issue 5 - this one may be related to Issue 4

When selecting a specific owned account that is not the default account, the tabs of the 'To' section (Recent, Saved, My accounts) are empty.

Screen.Recording.2025-01-29.at.6.02.57.PM.mov

Issue 6

No error indicator shows when user changes from an account with balance to an account with no balance.

SD-408:

Given an asset and amount to send is already set
When the user clicks on an account
And that account has no balance for the preselected asset
Then that account becomes selected account
And Max button is highlighted in red
And input value is highlighted in red
And Error message is shown at the bottom with an option to add token

Instead of the expected result (highlighted items in red) the account shows the 'select token' button

Screen.Recording.2025-01-30.at.4.16.45.PM.mov

This error shows on the console log

ERR 2025-01-30 19:15:15.915Z qt error topics="qt" tid=18917649 text="\nfromExponent (qrc:/StatusQ/Core/Utils/AmountsArithmetic.qml:100)\nexpression for selectedAmount (qrc:/app/AppLayouts/Wallet/adaptors/SignSendAdaptor.qml:56)\n (qrc:/app/AppLayouts/Wallet/popups/simpleSend/SimpleSendModal.qml:276)\n (qrc:/StatusQ/Core/Backpressure/Backpressure.qml:108)\n (qrc:/StatusQ/Core/Backpressure/Backpressure.qml:33)" file=qrc:/StatusQ/Core/Utils/AmountsArithmetic.qml:100 category=default

Issue 7

Switching between balance in Fiat and balance in assets changes to 0,00 Fiat when switching amounts when the user does not have enough balance.

1. Open the Send modal
2. Select a token, for example SNT
3. Before entering a number, switch to fiat amount
4. Enter an amount higher than the account's balance
5. click on the Switch icon to switch to SNT balance
6. Notice that the fiat balance below the SNT balance is 0,00

Screen.Recording.2025-01-30.at.4.27.39.PM.mov

Issue 8

Dark mode - hovering the items of the account selector do not highlight the items.
This works fine with other elements such as Network selector or token selector.

Screen.Recording.2025-01-30.at.4.35.46.PM.mov