Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

persist example broken #248

Closed
zangster300 opened this issue Nov 26, 2024 · 2 comments
Closed

persist example broken #248

zangster300 opened this issue Nov 26, 2024 · 2 comments
Assignees
@delaneyj
Labels
bug Something isn't working
Milestone
v0.21.0

Comments

@zangster300
Copy link
Contributor

https://data-star.dev/examples/persist

when entering a value, the value does not persist between page loads (tested on Chrome)
@zangster300 zangster300 mentioned this issue Nov 26, 2024
Closed
@delaneyj delaneyj added the bug Something isn't working label Nov 26, 2024
@bencroker
Copy link
Collaborator

bencroker commented Nov 26, 2024 •
edited
Loading

Tracked this down to the store only being updated on SSE events:

datastar/code/ts/library/src/plugins/official/attributes/storage/persist.ts

Line 32 in a02c0f1

const storeUpdateHandler = ((_: CustomEvent<DatastarSSEEvent>) => {

@bencroker bencroker added this to the v0.21.0 milestone Nov 29, 2024
@delaneyj
Copy link
Collaborator

delaneyj commented Dec 5, 2024

Fixed in #296

@delaneyj delaneyj closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delaneyj delaneyj

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.21.0
Development

No branches or pull requests
3 participants
@delaneyj @bencroker @zangster300