Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor support for Emacs #47

Open
searls opened this issue Dec 13, 2018 · 4 comments
Open

Editor support for Emacs #47

searls opened this issue Dec 13, 2018 · 4 comments
Labels
good first issue ⭐️ Good for newcomers help wanted 🙇‍♂️ Extra attention is needed tool integrations 🛠 Integrations with editors and tools

Comments

@searls
Copy link
Contributor

searls commented Dec 13, 2018

Fork rubocop-emacs, maybe?

@searls searls added help wanted 🙇‍♂️ Extra attention is needed good first issue ⭐️ Good for newcomers tool integrations 🛠 Integrations with editors and tools labels Dec 13, 2018
@rosston
Copy link
Contributor

rosston commented Dec 13, 2018

Adding support to Flycheck (either directly or via extension) might be a better option for Emacs support. Spacemacs uses it by default, so I think it's rather popular. And I think it would avoid the need to build a standardrb-mode.

@rosston
Copy link
Contributor

rosston commented Dec 13, 2018

Re Flycheck: it's probably worth noting that there probably won't be support for fixing anytime soon, judging by flycheck/flycheck#530.

@knu
Copy link
Contributor

knu commented Dec 13, 2018

I could write a formatter definition for format-all.

@mkornblum
Copy link

Howdy, updates for this issue:

@knu did indeed write a formatter, which is now part of format-all: lassik/emacs-format-all-the-code#107

I got standardrb linting + auto format on save working yesterday with standardrb, the newest version of format-all, flycheck-standardrb, and the following config in a .dir-locals.el file in my project directory:

((ruby-mode
  (format-all-formatters ("Ruby" standardrb))
  (eval . (format-all-mode 1))
  (flycheck-disabled-checkers . 'ruby-rubocop)))

I'm using doom-emacs and the version of format-all currently included with it appears to be pretty old, so I had to explicitly install a newer version. There's an open issue about this on the doom emacs repo. Mentioning that here just because doom is quite popular these days!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue ⭐️ Good for newcomers help wanted 🙇‍♂️ Extra attention is needed tool integrations 🛠 Integrations with editors and tools
Projects
None yet
Development

No branches or pull requests

4 participants