Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added save_single_paths #768

Closed
wants to merge 1 commit into from
Closed

added save_single_paths #768

wants to merge 1 commit into from

Conversation

aphc14
Copy link

@aphc14 aphc14 commented Sep 19, 2024 •
edited
Loading

fixes: #770

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Expose the save_single_paths argument to pathfinder class to view the csv, json and txt outputs of Pathfinder.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

  • Copyright Holder: Michael Cao

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

bob-carpenter
bob-carpenter requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@bob-carpenter bob-carpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The save_single_paths argument to pathfinder should be documented and tested somewhere before this gets merged.

@aphc14 aphc14 mentioned this pull request Oct 2, 2024
Open
@aphc14 aphc14 closed this Oct 2, 2024
@aphc14 aphc14 deleted the save_paths_fix branch October 2, 2024 06:57
@aphc14 aphc14 restored the save_paths_fix branch October 2, 2024 06:59
@aphc14 aphc14 deleted the save_paths_fix branch October 2, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bob-carpenter bob-carpenter bob-carpenter requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot set the save_single_paths argument to Pathfinder model
2 participants
@aphc14 @bob-carpenter