Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Cargo feature flag to skip "Bitcoin" tests #5802

Open
obycode opened this issue Feb 4, 2025 · 0 comments
Open

Use new Cargo feature flag to skip "Bitcoin" tests #5802

obycode opened this issue Feb 4, 2025 · 0 comments

Comments

@obycode
Copy link
Contributor

obycode commented Feb 4, 2025

I don't like that this prevents us from using ignored to actually ignore a test. What if we take this opportunity to use a different technique for these tests, and instead of marking them all as ignored, we only mark the ones that we want to ignore as ignored, and for the others we could use a new Cargo feature flag to ensure the simple CI job ignores them?

The added benefit is that we would see directly at the source of the test that it really is being ignored.

Originally posted by @obycode in #5763 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

1 participant