Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update http log when sending traffic #5786

Open
CharlieC3 opened this issue Jan 31, 2025 · 2 comments
Open

Update http log when sending traffic #5786

CharlieC3 opened this issue Jan 31, 2025 · 2 comments
Labels
good first issue Appropriate for a new open source contribution.

Comments

@CharlieC3
Copy link
Member

stacks-core/stackslib/src/net/httpcore.rs

Line 1911 in 9c8ed7b

"Timed out while receiving request",

This log reports it's receiving a request when it's actually sending a request.
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Jan 31, 2025
@CharlieC3 CharlieC3 added the good first issue Appropriate for a new open source contribution. label Jan 31, 2025
@jcnelson
Copy link
Member

Also, we should add a heartbeat log in the send and recv loops, and make sure the socket is non-blocking. The heartbeat can be info!-level, and it could report a heartbeat about the message in transit once per minute or some such.

@manojks1999
Copy link

@jcnelson can I work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Appropriate for a new open source contribution.
Projects
Stacks Core Eng
Status: Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcnelson @CharlieC3 @manojks1999