Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Page through Emily deposit requests #1148

Open
1 task
djordon opened this issue Dec 16, 2024 · 0 comments · May be fixed by #1252
Open
1 task

[Bug]: Page through Emily deposit requests #1148

djordon opened this issue Dec 16, 2024 · 0 comments · May be fixed by #1252
Assignees
Labels
bug Something isn't working sbtc signer binary The sBTC Bootstrap Signer.

Comments

@djordon
Copy link
Collaborator

djordon commented Dec 16, 2024

Bug - Page through Emily deposit requests

1. Description

We currently do not page through deposit requests when we ask Emily for all Pending deposits, but we should. sBTC is going to be a smashing success and everyone will want to bridge into the system.

1.1 Context & Purpose

We need to make sure that we get all deposits from Emily in a fixed amount of time (as in, not an indefinite amount of time).

2. Technical Details:

Emily supports pagination with a next page token; we should use it. But doing pagination does not completely fix the issue because it doesn't allow us to guarantee that we'd eventually process all deposits. For that we'd have to limit the amount of time that we spend fetching requests from Emily. We'd also have to make sure that we can resume fetching deposit requests past a certain block height or other marker.

2.1 Acceptance Criteria:

  • We iterate through deposit requests stored in Emily so that we can eventually get through all of them.

3. Related Issues and Pull Requests (optional):

@djordon djordon added bug Something isn't working sbtc signer binary The sBTC Bootstrap Signer. labels Dec 16, 2024
@djordon djordon added this to the sBTC: Release polish milestone Dec 16, 2024
@djordon djordon added this to sBTC Dec 16, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Dec 16, 2024
@djordon djordon moved this from Needs Triage to Todo in sBTC Dec 16, 2024
@Jiloc Jiloc self-assigned this Jan 21, 2025
@Jiloc Jiloc moved this from Todo to In Progress in sBTC Jan 21, 2025
@Jiloc Jiloc linked a pull request Jan 21, 2025 that will close this issue
3 tasks
@Jiloc Jiloc moved this from In Progress to In Review in sBTC Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

3 participants