Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Retry p2p seed peers #1133

Open
1 task
djordon opened this issue Dec 14, 2024 · 3 comments · May be fixed by #1257
Open
1 task

[Feature]: Retry p2p seed peers #1133

djordon opened this issue Dec 14, 2024 · 3 comments · May be fixed by #1257
Assignees
Labels
sbtc signer binary The sBTC Bootstrap Signer. signer communication Communication across sBTC bootstrap signers.

Comments

@djordon
Copy link
Collaborator

djordon commented Dec 14, 2024

Feature - Retry p2p seed peers

1. Description

1.1 Context & Purpose

2. Technical Details:

2.1 Acceptance Criteria:

  • If a signer cannot reach out to the seed peers, they should try again after some delay.

3. Related Issues and Pull Requests (optional):

@djordon djordon added sbtc signer binary The sBTC Bootstrap Signer. signer communication Communication across sBTC bootstrap signers. labels Dec 14, 2024
@djordon djordon added this to the sBTC: Release polish milestone Dec 14, 2024
@djordon djordon added this to sBTC Dec 14, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Dec 14, 2024
@cylewitruk
Copy link
Member

Hm.. this should be done automatically. I'm guessing that we may be incorrectly purging them at some point, where we should probably never automatically remove a seed peer.

@djordon
Copy link
Collaborator Author

djordon commented Dec 15, 2024

I see an issue like this locally, where one signer does not connect to any of the others. Well, that's probably a different issue than what happens in production though (if it happens at all). Anyway, this ticket might be a little premature, but I thought that it might be an actual issue given what I see locally.

@cylewitruk
Copy link
Member

I see an issue like this locally, where one signer does not connect to any of the others. Well, that's probably a different issue than what happens in production though (if it happens at all). Anyway, this ticket might be a little premature, but I thought that it might be an actual issue given what I see locally.

I'll have a peek tomorrow and see if I can't reproduce; not sure i've seen it 🤔

@cylewitruk cylewitruk moved this from Needs Triage to In Progress in sBTC Dec 16, 2024
@cylewitruk cylewitruk moved this from In Progress to Todo in sBTC Jan 20, 2025
@cylewitruk cylewitruk moved this from Todo to In Progress in sBTC Jan 21, 2025
@cylewitruk cylewitruk linked a pull request Jan 22, 2025 that will close this issue
4 tasks
@cylewitruk cylewitruk linked a pull request Jan 22, 2025 that will close this issue
4 tasks
@djordon djordon moved this from In Progress to In Review in sBTC Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer. signer communication Communication across sBTC bootstrap signers.
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

3 participants