From 4642e66e37d548a171e34ef0d677b2531e4e7eb5 Mon Sep 17 00:00:00 2001
From: cylewitruk <cyle.witruk@outlook.com>
Date: Thu, 6 Feb 2025 00:58:46 +0100
Subject: [PATCH] pr comments utxo

---
 signer/src/bitcoin/utxo.rs | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/signer/src/bitcoin/utxo.rs b/signer/src/bitcoin/utxo.rs
index 71cad1745..e6c8e4fd7 100644
--- a/signer/src/bitcoin/utxo.rs
+++ b/signer/src/bitcoin/utxo.rs
@@ -828,7 +828,7 @@ impl UnsignedMockTransaction {
     /// construct a [`Transaction`] with a single input and output.
     pub fn new(signer_public_key: XOnlyPublicKey) -> Self {
         let utxo = SignerUtxo {
-            outpoint: OutPoint::new(Txid::all_zeros(), 0),
+            outpoint: OutPoint::null(),
             amount: Self::AMOUNT,
             public_key: signer_public_key,
         };
@@ -839,7 +839,7 @@ impl UnsignedMockTransaction {
             input: vec![utxo.as_tx_input(&DUMMY_SIGNATURE)],
             output: vec![TxOut {
                 value: Amount::from_sat(Self::AMOUNT),
-                script_pubkey: ScriptBuf::new_op_return([0x01, 0x02, 0x03]),
+                script_pubkey: ScriptBuf::new_op_return([]),
             }],
         };
 
@@ -1782,13 +1782,13 @@ mod tests {
         // Sign the taproot sighash.
         let message = secp256k1::Message::from_digest_slice(tapsig.as_byte_array())
             .expect("Failed to create message");
+
+        // [1] Verify the correct signature, which should succeed.
         let schnorr_sig = secp.sign_schnorr(&message, &tweaked.to_inner());
         let taproot_sig = bitcoin::taproot::Signature {
             signature: schnorr_sig,
             sighash_type: TapSighashType::All,
         };
-
-        // [1] Verify the correct signature, which should succeed.
         unsigned
             .verify_signature(&taproot_sig)
             .expect("signature verification failed");
@@ -1827,6 +1827,17 @@ mod tests {
         unsigned
             .verify_signature(&taproot_sig)
             .expect_err("signature verification should have failed");
+
+        // [5] Same as [4], but using its tweaked key.
+        let tweaked = keypair.tap_tweak(&secp, None);
+        let schnorr_sig = secp.sign_schnorr(&message, &tweaked.to_inner());
+        let taproot_sig = bitcoin::taproot::Signature {
+            signature: schnorr_sig,
+            sighash_type: TapSighashType::All,
+        };
+        unsigned
+            .verify_signature(&taproot_sig)
+            .expect_err("signature verification should have failed");
     }
 
     #[ignore = "For generating the SOLO_(DEPOSIT|WITHDRAWAL)_SIZE constants"]