From 40100f8e38b5dae1339f497953481d275fb3d8e0 Mon Sep 17 00:00:00 2001 From: djordon Date: Mon, 7 Oct 2024 13:32:05 -0400 Subject: [PATCH] random comment update --- signer/src/keys.rs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/signer/src/keys.rs b/signer/src/keys.rs index f81fc4b11..edf065085 100644 --- a/signer/src/keys.rs +++ b/signer/src/keys.rs @@ -113,11 +113,10 @@ impl From<&PublicKey> for p256k1::point::Point { // [^2]: https://github.com/bitcoin-core/secp256k1/blob/v0.3.0/src/field.h#L78-L79 let x_element = p256k1::field::Element::from(x_part); let y_element = p256k1::field::Element::from(y_part); - // You would think that you couldn't always convert two elements - // into a Point, but `p256k1::point::Point::from` uses - // `secp256k1_gej_set_ge` under the hood, which I believe does any - // reduction. But still, we have a valid public key, so no - // reductions should be necessary. + // You cannot always convert two aribtrary elements into a Point, + // and `p256k1::point::Point::from` assumes that it is being given + // two elements that from a point in affine coordinates. We have a + // valid public key, so we know that this assumption is upheld. p256k1::point::Point::from((x_element, y_element)) } }