Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate by default #1504

Closed
gadomski opened this issue Jan 24, 2025 · 1 comment · Fixed by #1509
Closed

Migrate by default #1504

gadomski opened this issue Jan 24, 2025 · 1 comment · Fixed by #1509
Assignees

Comments

@gadomski
Copy link
Member

As described in #1503 (comment), our from_file method migrates to the latest version by default, but from_dict does not. This can lead to confusing discrepancies in behavior depending on how STAC data gets into pystac. I think we should align on migrate-by-default, as we will continue to see more and more STAC (and extension) versions as time goes on.

This could be as simple as change the from_dict default. This could lead to unexpected behavior for some users but IMO that'd be worth it, and not a breaking change. Thoughts?

@gadomski gadomski self-assigned this Jan 24, 2025
@gadomski gadomski mentioned this issue Jan 24, 2025
3 tasks
@jsignell
Copy link
Member

Yeah I like migrate by default. People can stay on an old version of pystac if they want to be using an old API for interacting with their STAC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants