Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JFXRippler -fx-background-radius ignored #724

Open
lorenzo-geromel opened this issue May 23, 2018 · 5 comments
Open

JFXRippler -fx-background-radius ignored #724

lorenzo-geromel opened this issue May 23, 2018 · 5 comments
Labels

Comments

@lorenzo-geromel
Copy link

lorenzo-geromel commented May 23, 2018

If you use the -fx-background-radius attribute on a JFXRippler object, it will be ignored.

Example:

Button btn = new Button("This is a Rippler test!");
btn.setStyle("-fx-background-radius: 50; -fx-background-color: #3F51B5;");
JFXRippler rippler = new JFXRippler(btn);
rippler.setStyle("-fx-background-radius: 50; -jfx-rippler-fill: #EEEEEE;");

This code will generate a rippler that exceeds the button corners, as you can see on these screenshots.

rippler_1

rippler_2

Any help?

@lorenzo-geromel lorenzo-geromel changed the title JFXRippler background radius ignored JFXRippler- fx-background-radius ignored May 24, 2018
@lorenzo-geromel lorenzo-geromel changed the title JFXRippler- fx-background-radius ignored JFXRippler -fx-background-radius ignored May 24, 2018
@jfoenixadmin
Copy link
Collaborator

how about using JFXButton instead?

@lorenzo-geromel
Copy link
Author

That's still a problem, that was just a quick example.
I actually use a JFXRippler which contains many items, like labels and imageviews, and it's really ugly to see the rounded background corners with a squared ripple.

So, any ideas?

@jfoenixadmin
Copy link
Collaborator

well, you can extend JFXRippler and override the method getMask()

@lorenzo-geromel
Copy link
Author

Thanks a lot, I'll try

@stale
Copy link

stale bot commented Jan 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 7, 2019
@stale stale bot removed the wontfix label Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants