Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CandidatesGenerator.__eq__ is broken #429

Open
m09 opened this issue Dec 11, 2018 · 0 comments
Open

CandidatesGenerator.__eq__ is broken #429

m09 opened this issue Dec 11, 2018 · 0 comments
Labels
bug Something isn't working typos

Comments

@m09
Copy link
Contributor

m09 commented Dec 11, 2018 •
edited
Loading

Currently, CandidatesGenerator.__eq__ has broken logic: it only checks the equality of one attribute and then returns. It also has over-complicated equality logic that should be delegated to its attributes' classes.
@m09 m09 added bug Something isn't working typos labels Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working typos
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m09