Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FeatureExtractror to have fit() and transform() methods #401

Open
zurk opened this issue Dec 9, 2018 · 2 comments
Open

Refactor FeatureExtractror to have fit() and transform() methods #401

zurk opened this issue Dec 9, 2018 · 2 comments
Labels
enhancement New feature or request format Issues related to format analyzer refactor

Comments

@zurk
Copy link
Contributor

zurk commented Dec 9, 2018

Ancestor issue: #387

The problem is that feature extraction is different when you train the model and when you apply it.
So it is clear that FeatureExtractor is a transformer and fit() and transform() methods should be implemented. It helps to reduce code complexity a lot. Now we have both methods implemented inside extract_features() and index_labels flag turns it to fit or transform method.

@zurk zurk added the enhancement New feature or request label Dec 9, 2018
@m09
Copy link
Contributor

m09 commented Dec 9, 2018

Fit and transform is actually not the API we want. We want fit_transform & save for the training and load & transform for the testing.

@zurk
Copy link
Contributor Author

zurk commented Dec 9, 2018

yeah, you are right, I just decompose fit_transform to fit + transform :)

@m09 m09 added the format Issues related to format analyzer label Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request format Issues related to format analyzer refactor
Projects
None yet
Development

No branches or pull requests

3 participants