Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize quote handling stuff in Rules #381

Open
m09 opened this issue Dec 7, 2018 · 0 comments
Open

Centralize quote handling stuff in Rules #381

m09 opened this issue Dec 7, 2018 · 0 comments
Assignees
@EgorBu
Labels
enhancement New feature or request format Issues related to format analyzer medium Medium size refactor
Milestone
Refactoring Janua...

Comments

@m09
Copy link
Contributor

m09 commented Dec 7, 2018

ATM we have harmonize_quotes in Rules and another piece of logic in the code generator to check if quotes predictions are applicable. We should centralize those two functions in one place (and call them both in Rules.predict).
@m09 m09 added the enhancement New feature or request label Dec 7, 2018
@m09 m09 added the format Issues related to format analyzer label Dec 11, 2018
@vmarkovtsev vmarkovtsev added this to the Refactoring January 2019 milestone Jan 10, 2019
@vmarkovtsev vmarkovtsev added the medium Medium size label Jan 10, 2019
@vmarkovtsev vmarkovtsev assigned EgorBu and unassigned m09 Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EgorBu EgorBu

Labels
enhancement New feature or request format Issues related to format analyzer medium Medium size refactor
Projects
None yet
Milestone
Refactoring January 2019
Development

No branches or pull requests
3 participants
@m09 @EgorBu @vmarkovtsev