Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize node classes imports #286

Open
zurk opened this issue Oct 29, 2018 · 0 comments
Open

Optimize node classes imports #286

zurk opened this issue Oct 29, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request format Issues related to format analyzer medium Medium size refactor

Comments

@zurk
Copy link
Contributor

zurk commented Oct 29, 2018

It helps to replace such huge imports

from lookout.style.format.feature_utils import (
    CLASS_INDEX, CLASSES, CLS_DOUBLE_QUOTE, CLS_NEWLINE, CLS_NOOP, CLS_SINGLE_QUOTE, CLS_SPACE,
    CLS_SPACE_DEC, CLS_SPACE_INC, CLS_TAB, CLS_TAB_DEC, CLS_TAB_INC)

with just

from lookout.style.format.feature_utils import CLASS

(naming should be better.)

Also, it is a good idea to add such function as is_emply, is_indentation etc.

I can take this issue but after the release.

@zurk zurk added the enhancement New feature or request label Oct 29, 2018
@m09 m09 added the format Issues related to format analyzer label Dec 11, 2018
@vmarkovtsev vmarkovtsev added this to the Refactoring January 2019 milestone Jan 10, 2019
@vmarkovtsev vmarkovtsev changed the title Join all code related to VirtualNode classes to one class Optimize node class imports Jan 10, 2019
@vmarkovtsev vmarkovtsev changed the title Optimize node class imports Optimize node classes imports Jan 10, 2019
@vmarkovtsev vmarkovtsev added the medium Medium size label Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request format Issues related to format analyzer medium Medium size refactor
Projects
None yet
Development

No branches or pull requests

4 participants