Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment configuration on CLI #176

Open
smola opened this issue Sep 28, 2018 · 2 comments
Open

Environment configuration on CLI #176

smola opened this issue Sep 28, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@smola
Copy link
Contributor

smola commented Sep 28, 2018

  • Environment configuration should be read from environment variables (database, filesystem paths, endpoints). It's useful to have them as CLI flags too (see borges for an example, which uses both), but environment variables are usually more convenient to reuse them. YAML config is something we have avoided so far in other projects.
  • Default values should be provided where it makes sense. For example, defaults explained in the README.
@smola smola added the enhancement New feature or request label Sep 28, 2018
@vmarkovtsev
Copy link
Collaborator

Environment variables should be already supported thanks to the package we use for parsing the command line.

But anyway I don't like env vars because they make the configuration implicit compared to explicit pointing to the configuration file. I had so much bad experience with implicit expectation of the environment vars in different applications.

@vmarkovtsev
Copy link
Collaborator

@smola not sure if we are on the same page: command line arguments are currently duplicated in the config file, and the user is not required to use a configuration file at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants