Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use celery for dashboards #307

Open
carlosms opened this issue Jun 18, 2019 · 4 comments
Open

Use celery for dashboards #307

carlosms opened this issue Jun 18, 2019 · 4 comments
Labels
enhancement New feature or request needs discussion/agreement This issue needs some discussion or agreement

Comments

@carlosms
Copy link
Contributor

This issue is to see if there is any configuration that will allow us to run at most 1 parallel query to gitbase.

From local testing we have detected that disk-intensive gitbase queries will perform better sequentially than in parallel.

@smacker
Copy link
Contributor

smacker commented Jun 18, 2019

For charts currently, we are limit by the number of workers (5). Most probably for 5 concurrent requests, the difference isn't big enough to invest time in it. I would keep this issue in the backlog but wouldn't really put in TODO.

@smacker
Copy link
Contributor

smacker commented Jun 21, 2019

in master it's not 5 anymore but $((2 * $(getconf _NPROCESSORS_ONLN) + 1)).

@smacker
Copy link
Contributor

smacker commented Jun 21, 2019

proper way to fix it is to use celery for dashboards. Then we can control the number of connection from config for sourced-ui (currently we run only 1 celery worker for example) and it would solve #121 as well.

@se7entyse7en
Copy link
Contributor

proper way to fix it is to use celery for dashboards.

I guess this is not trivial to do on our fork without messing up next update of superset, am I wrong? Do you also have any information about development in this direction of using celery for dashboards as well upstream?

@se7entyse7en se7entyse7en transferred this issue from src-d/sourced-ce Oct 18, 2019
@se7entyse7en se7entyse7en changed the title Limit gitbase concurrent queries Use celery for dashboards Oct 18, 2019
@se7entyse7en se7entyse7en added enhancement New feature or request needs discussion/agreement This issue needs some discussion or agreement labels Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs discussion/agreement This issue needs some discussion or agreement
Projects
None yet
Development

No branches or pull requests

3 participants