Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oauth support #308

Merged
merged 3 commits into from
Oct 22, 2019
Merged

Oauth support #308

merged 3 commits into from
Oct 22, 2019

Conversation

smacker
Copy link
Contributor

@smacker smacker commented Oct 18, 2019

Fix: #293
Supersedes: #292

  • Changed the configuration proposed by Alex a little to make it less nesting
  • Added documentation to README and Changelog
  • The error after login was fixed by updating to superset v0.34.1 Bump flask-appbuilder to 2.1.13 apache/superset#8174
  • Users can access users list when registered with Admin role.
  • Wasted 2 hours of my life due to cache in docker

  • I have updated the CHANGELOG file according to the conventions in keepachangelog.com
  • This PR contains changes that do not require a mention in the CHANGELOG file

Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker smacker requested a review from a team October 18, 2019 16:11
| `OAUTH_PROVIDER` | Use OAuth provider for authorization. Currently only `google` |
| `OAUTH_CONSUMER_KEY` | OAuth provider consumer key (aka client_id) |
| `OAUTH_CONSUMER_SECRET` | OAuth provider consumer secret (aka client_secret) |
| `OAUTH_REGISTRATION_ROLE` | The role for newly registered users using OAuth `Admin`/`Alpha`/`Gamma` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you link to doc or explain the difference here?

@smacker
Copy link
Contributor Author

smacker commented Oct 22, 2019

link added.

@smacker smacker merged commit b17b7af into src-d:master Oct 22, 2019
@dpordomingo dpordomingo mentioned this pull request Nov 7, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for configuring Google OAuth logins
2 participants