Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ids in json_metadata on import #288

Closed
smacker opened this issue Sep 25, 2019 · 3 comments · Fixed by #294
Closed

Update ids in json_metadata on import #288

smacker opened this issue Sep 25, 2019 · 3 comments · Fixed by #294
Assignees

Comments

@smacker
Copy link
Contributor

smacker commented Sep 25, 2019

Currently import fixes ids for position_json but not json_metadata. As the results default_filters for example are broken.

@se7entyse7en
Copy link
Contributor

Are default_filters those applied by the filter widgets in the dashboard? And when you refer to the ids fixing on position_json, is this something that was done on our side only or included upstream? Do you have a link to the related PR/issue?

@smacker
Copy link
Contributor Author

smacker commented Sep 27, 2019

And when you refer to the ids fixing on position_json, is this something that was done on our side only or included upstream?

it was always in upstream: https://github.com/src-d/sourced-ui/blob/master/superset/superset/models/core.py#L550

Are default_filters those applied by the filter widgets in the dashboard?

those filters applied to the filter widget and to all charts in the dashboard. (unless they are in filter_immune_slices or filter_immune_slice_fields which we also don't update but should) Ref: http://superset.apache.org/faq.html#how-to-add-dynamic-filters-to-a-dashboard

@se7entyse7en
Copy link
Contributor

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants