Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When running with https favorite status is still requested with http #278

Closed
se7entyse7en opened this issue Sep 10, 2019 · 7 comments · Fixed by #300
Closed

When running with https favorite status is still requested with http #278

se7entyse7en opened this issue Sep 10, 2019 · 7 comments · Fixed by #300
Labels
bug Something isn't working

Comments

@se7entyse7en
Copy link
Contributor

For a demo environment running with https, when opening a dashboard the request for favorite status is done on http causing an error, and shows banner 'There was an issue fetching the favorite status of this dashboard.'
@se7entyse7en se7entyse7en added the bug Something isn't working label Sep 10, 2019
@se7entyse7en
Copy link
Contributor Author

For demos this has been fixed by removing the catch of the error.

@smacker
Copy link
Contributor

smacker commented Sep 26, 2019

The proper fix is included in v0.34.1: apache/superset#8013
We can backport it or just wait a bit.

@se7entyse7en
Copy link
Contributor Author

Great that has been fixed upstream 👍

@se7entyse7en
Copy link
Contributor Author

I'd backport it as it is a very isolated thing and also would remove us a step when setting up demos.

@smacker
Copy link
Contributor

smacker commented Oct 9, 2019

There are enough votes for releasing 0.34.1rc2 as 0.34.1 already from Superset team.
72 hours voting process by Apache Incubator started 2 days ago.
https://lists.apache.org/thread.html/e60f080ebdda26896214f7d3d5be1ccadfab95d48fbe813252762879@%3Cdev.superset.apache.org%3E

it makes sense to wait and update srcd-ui to 0.34.1.

@se7entyse7en
Copy link
Contributor Author

Thanks for the link! Yes then, let's wait 👍

@smacker
Copy link
Contributor

smacker commented Oct 11, 2019

released: https://github.com/apache/incubator-superset/releases/tag/0.34.1

@smacker smacker mentioned this issue Oct 17, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Superset 0.34.1
2 participants
@smacker @se7entyse7en