Dockerfile optimized #275
Dockerfile optimized #275
Conversation
Signed-off-by: Lou Marvin Caraig <[email protected]>
Signed-off-by: Lou Marvin Caraig <[email protected]>
Signed-off-by: Lou Marvin Caraig <[email protected]>
Signed-off-by: Lou Marvin Caraig <[email protected]>
| && pip install -r requirements.txt -r requirements-dev.txt -r requirements-extra.txt \ | ||
| && rm -rf /root/.cache/pip | ||
| && pip install --no-index --find-links=/wheels \ | ||
| -r requirements.txt -r requirements-dev.txt -r requirements-extra.txt \ |
There was a problem hiding this comment.
requirements-dev are needed only for dev :)
(except db drivers which we should move to another file)
There was a problem hiding this comment.
yup, this doesn't address #272. The reason is that as you said we should also reorg requirements files such as whether to store our requirements in a requirements-build.txt or whatever where we store db drivers and pyHive. I wanted to separate this PR which is more general.
superset/contrib/docker/Dockerfile
Outdated
|
|
||
| COPY superset/assets superset/assets | ||
|
|
||
| RUN cd superset/assets \ |
There was a problem hiding this comment.
This also improves the usage of docker caching for this step that is really heavy.
if you want to improve it further you can do:
# install deps and cache them
COPY superset/assets/package*.json superset/assets
RUN npm ci
# build
COPY superset/assets superset/assets
RUN npm run build
It will use docker cache instead of downloading and installing dependencies most of the time.
There was a problem hiding this comment.
Thanks! Done here.
superset/contrib/docker/Dockerfile
Outdated
| @@ -14,7 +14,34 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
| # | |||
| FROM python:3.6-jessie | |||
| FROM node:12 AS static | |||
There was a problem hiding this comment.
node version in build stage and in the final image aren't the same. Most probably it's not important but anyway better make them match.
There was a problem hiding this comment.
Good catch! Fixed here.
Signed-off-by: Lou Marvin Caraig <[email protected]>
Signed-off-by: Lou Marvin Caraig <[email protected]>
Closes #273.
This doesn't address #272.
The
Dockerfilehas been modified in order to reduce the final image size. This is achieved by using multi-stage build. There are two builders:The first builder compiles the static files and permits the final image to avoid installing nodejs for the production version. This also improves the usage of docker caching for this step that is really heavy.
The second builder builds the python wheels to be used in the final image. This permits to use the slim image version.
The final image depends on the build arg
DEV_BUILD: ifDEV_BUILDistrue, then also os dev dependencies are installed, otherwise, they're not. The Makefile provides thebuild-devtarget.The production image size has decreased from
1.76GBto945MB(decrease>800MB, -46%).The development image size has decreased from
1.76GBto1.1GB(decrease>650MB, -37.5%).