Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idea] Different docker images for prod and dev #273

Closed
se7entyse7en opened this issue Sep 2, 2019 · 1 comment · Fixed by #275
Closed

[idea] Different docker images for prod and dev #273

se7entyse7en opened this issue Sep 2, 2019 · 1 comment · Fixed by #275
Assignees

Comments

@se7entyse7en
Copy link
Contributor

Related to #272.

This actually a more general issue that includes #272.

The current Dockerfile installs a lot of things that are actually not needed to just run the service. I don't know the impact, but most probably we can reduce the total size of the image considerably.

Among these there's also nodejs that is needed to compile the static files. In case of a prod docker image, would it be possible to use a multi-stage build so that in the final image we only have the required compiled static files?

@smacker
Copy link
Contributor

smacker commented Sep 2, 2019

It's possible to pass env variables to docker build which would allow us to use the same Dockerfile but build different versions with and without dev deps depends on the variable.

@se7entyse7en se7entyse7en self-assigned this Sep 3, 2019
@se7entyse7en se7entyse7en mentioned this issue Sep 3, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants