Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python dev dependencies from the image #286

Merged
merged 3 commits into from
Sep 30, 2019
Merged

Remove python dev dependencies from the image #286

merged 3 commits into from
Sep 30, 2019

Conversation

smacker
Copy link
Contributor

@smacker smacker commented Sep 24, 2019

The production image size has decreased from 933MB to 811MB.

Fix: #272

Signed-off-by: Maxim Sukharev [email protected]


  • I have updated the CHANGELOG file according to the conventions in keepachangelog.com
  • This PR contains changes that do not require a mention in the CHANGELOG file

@smacker smacker requested a review from a team September 24, 2019 15:26
@smacker
Copy link
Contributor Author

smacker commented Sep 24, 2019

CI is failing, I'm not sure why. Investigating...

@se7entyse7en
Copy link
Contributor

CI is failing, I'm not sure why. Investigating...

Most probably it's because you need to modify tox.ini to include installation of extra deps in each tox env. No need to install them in travis step.

@smacker
Copy link
Contributor Author

smacker commented Sep 25, 2019

Yeah. I figured it too. Thanks.

The production image size has decreased from `933MB` to `811MB`.

Fix: #272

Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker
Copy link
Contributor Author

smacker commented Sep 27, 2019

rebased to solve conflicts on changelog

@smacker smacker merged commit 4c093e1 into src-d:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary python deps in docker image
3 participants