Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taking the integer part of number is not in the format options #248

Closed
warenlg opened this issue Aug 12, 2019 · 1 comment
Closed

Taking the integer part of number is not in the format options #248

warenlg opened this issue Aug 12, 2019 · 1 comment

Comments

@warenlg
Copy link

warenlg commented Aug 12, 2019

A lot of time, especially with Big Number-s, the format options suggested are not satisfying. For example, sometimes we output 48.0 or 50, whereas the integer part should be taken here.

Some related discussions https://src-d.slack.com/archives/CJQ0DBAJV/p1564509350025500
@warenlg warenlg mentioned this issue Aug 12, 2019
Closed
@warenlg
Copy link
Author

warenlg commented Aug 14, 2019

Using SMART_NUMBER is the solution for that

@warenlg warenlg closed this as completed Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add taking the integer part as a number format option warenlg/sourced-ui
1 participant
@warenlg