Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SQL Lab table previews with gitbase-spark-collector #245

Closed
carlosms opened this issue Aug 9, 2019 · 3 comments · Fixed by #263
Closed

Support SQL Lab table previews with gitbase-spark-collector #245

carlosms opened this issue Aug 9, 2019 · 3 comments · Fixed by #263
Assignees
@se7entyse7en

Comments

@carlosms
Copy link
Contributor

carlosms commented Aug 9, 2019

No description provided.

@smacker
Copy link
Contributor

smacker commented Aug 9, 2019

I'm not sure this issue should be in ui repo.
Preview for tables registered in spark work just fine. Views don't. (you can validate it on our demo instance)
Also there is a issue in gsc: https://github.com/src-d/gitbase-spark-connector-enterprise/issues/110
And dp team recomends to apply the fix to pyhive.

@se7entyse7en se7entyse7en mentioned this issue Aug 9, 2019
Closed
@se7entyse7en
Copy link
Contributor

Sorry, I opened #246 after seeing this. BTW the fix in pyhive doesn't work: that part of the code is not being used when the query for the preview is requested by the UI.

@se7entyse7en
Copy link
Contributor

The query is built by the select_star method that is then passed to the FE here.

@se7entyse7en se7entyse7en self-assigned this Aug 16, 2019
@se7entyse7en se7entyse7en mentioned this issue Aug 19, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@se7entyse7en se7entyse7en

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@smacker @carlosms @se7entyse7en