Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update current dashboards & queries for gitbase-spark-connector #235

Closed
carlosms opened this issue Aug 2, 2019 · 4 comments
Closed

Update current dashboards & queries for gitbase-spark-connector #235

carlosms opened this issue Aug 2, 2019 · 4 comments
Assignees

Comments

@carlosms
Copy link
Contributor

carlosms commented Aug 2, 2019

Replicate (and adapt when necessary) queries and dashboards from the current CE dashboards for EE.

If the queries are not compatible, we will need to have different json files for CE and EE. They should be loaded automatically on bootstrap, just like we do for CE.
We need to pay attention also to the internal links from the welcome dashboard to the other ones.

note: we already have an undocumented env var, MODE=Community/Enterprise, used in superset_config.py for the database connection string.

@carlosms carlosms changed the title Replicate CE Welcome dashboards & queries on EE Upde current dashboards & queries for gitbase-spark-connector Aug 9, 2019
@carlosms
Copy link
Contributor Author

carlosms commented Aug 9, 2019

With the new CE & EE roadmap, there is no need to keep both versions. The current dashboards need to be updated to work with gitbase-spark-connector.

For now we need to start working on it, to find incompatibilities and possible bugs in gitbase-spark-connector as soon as possible.
To help with development, let's work with PRs against a new branch, gsc. This way we can have smaller PRs before merging everything to master.

@carlosms carlosms added the blocked This is blocked for some reason label Aug 16, 2019
@carlosms
Copy link
Contributor Author

Adding the 'blocked' label because we should wait for #251 to be merged first.

@se7entyse7en
Copy link
Contributor

Removing the blocked label as #251 has been merged.

@se7entyse7en se7entyse7en removed the blocked This is blocked for some reason label Aug 30, 2019
@se7entyse7en se7entyse7en self-assigned this Aug 30, 2019
@se7entyse7en se7entyse7en changed the title Upde current dashboards & queries for gitbase-spark-connector Update current dashboards & queries for gitbase-spark-connector Aug 30, 2019
@se7entyse7en se7entyse7en mentioned this issue Sep 3, 2019
2 tasks
@se7entyse7en
Copy link
Contributor

se7entyse7en commented Oct 2, 2019

As discussed in [private] Apps Sync of 2019-10-02 this is a won't do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants