Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons does not keep size on action #185

Closed
dpordomingo opened this issue Jun 29, 2019 · 3 comments
Closed

Buttons does not keep size on action #185

dpordomingo opened this issue Jun 29, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@dpordomingo
Copy link
Contributor

Originally posted by @carlosms in #139 (comment)

I've found a missing change in button height. In this case it's a minor thing, but it means there might be other places where buttons are not consistent.

Before:
Peek 2019-06-28 10-39

After:
Peek 2019-06-28 10-38

@dpordomingo dpordomingo added the bug Something isn't working label Jun 29, 2019
@dpordomingo
Copy link
Contributor Author

dpordomingo commented Jun 29, 2019

I think that button size (width:height) should not change on active state, wdyt @ricardobaeta ?

@ricardobaeta
Copy link
Contributor

ricardobaeta commented Jul 3, 2019

Yes @dpordomingo I agree with you on this. It's already fixed as you can see 👇. It will be included on the typography-fixes PR. Once merged we can close this.

run-query-stop

ricardobaeta added a commit that referenced this issue Jul 4, 2019
This commit fixes the issues listed bellow, after we merged the Typography PR.

1) #185
2) #184
3) #183
4) #186

I'll be doing another commit to solve #192 and then will create a PR.

Signed-off-by: Ricardo Baeta <[email protected]>
@carlosms
Copy link
Contributor

carlosms commented Jul 5, 2019

Fixed in #196

@carlosms carlosms closed this as completed Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants