Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supported languages list from enry on gitbase documentation #658

Closed
ajnavarro opened this issue Dec 12, 2018 · 3 comments
Closed

Add supported languages list from enry on gitbase documentation #658

ajnavarro opened this issue Dec 12, 2018 · 3 comments
Assignees
@kuba--
Labels
blocked Some other issue is blocking this documentation This is a documentation issue or pull request

Comments

@ajnavarro
Copy link
Contributor

Issue extracted from #443
@ajnavarro ajnavarro added the documentation This is a documentation issue or pull request label Dec 12, 2018
@ajnavarro ajnavarro mentioned this issue Dec 12, 2018
Closed
@ajnavarro ajnavarro changed the title Add supported language list from enry on gitbase documentation Add supported languages list from enry on gitbase documentation Dec 12, 2018
@ajnavarro ajnavarro added the blocked Some other issue is blocking this label Dec 12, 2018
@ajnavarro
Copy link
Contributor Author

bblfsh/documentation#191

@ajnavarro ajnavarro reopened this Dec 12, 2018
@kuba-- kuba-- self-assigned this Dec 12, 2018
@kuba-- kuba-- mentioned this issue Dec 12, 2018
Merged
@smola
Copy link
Contributor

smola commented Dec 13, 2018

The issue in the linked issue is not in bblfsh:
LANGUAGE(t.tree_entry_name, b.blob_content) = 'go'

That's enry. You should link to https://github.com/src-d/enry/blob/master/data/alias.go or github/linguist for valid values. That could be a note in your documentation about the LANGUAGE function.

@smola
Copy link
Contributor

smola commented Dec 13, 2018

AFAIK go would be a valid value for bblfsh, the problem here is comparing it with LANGUAGE result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuba-- kuba--

Labels
blocked Some other issue is blocking this documentation This is a documentation issue or pull request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smola @ajnavarro @kuba--