From 0d321fdc8b1187db628a318a1e8c2de1a3beee02 Mon Sep 17 00:00:00 2001 From: M Bussonnier Date: Tue, 15 Oct 2024 12:04:52 +0200 Subject: [PATCH 1/2] Clarify test error rmessage. And precompute the delta-time as pytest's: > assert (1728139272.6514266 - 1728139262.6307526) < 5 Is not super useful to know how long the timeout was. In particular it allos us to see in ipykernels' main branch that the delta is >=10s, so that the interrupt call is not properly handled. --- spyder_kernels/console/tests/test_console_kernel.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/spyder_kernels/console/tests/test_console_kernel.py b/spyder_kernels/console/tests/test_console_kernel.py index f6f58c39..f86a6cac 100644 --- a/spyder_kernels/console/tests/test_console_kernel.py +++ b/spyder_kernels/console/tests/test_console_kernel.py @@ -1314,13 +1314,17 @@ def test_interrupt(): kernel_comm.remote_call().raise_interrupt_signal() # Wait for shell message while True: - assert time.time() - t0 < 5 + delta = time.time() - t0 + assert delta < 5 msg = client.get_shell_msg(timeout=TIMEOUT) if msg["parent_header"].get("msg_id") != msg_id: # not from my request continue break - assert time.time() - t0 < 5 + delta = time.time() - t0 + assert ( + delta < 5 + ), "10 second long call should have been interupted, interrupt signal was likely misshandled" def test_enter_debug_after_interruption(): From 1ed5791efef6d0a2eb20db47ef98dffb6e953458 Mon Sep 17 00:00:00 2001 From: M Bussonnier Date: Wed, 16 Oct 2024 22:18:39 +0200 Subject: [PATCH 2/2] Update spyder_kernels/console/tests/test_console_kernel.py Co-authored-by: Carlos Cordoba --- spyder_kernels/console/tests/test_console_kernel.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/spyder_kernels/console/tests/test_console_kernel.py b/spyder_kernels/console/tests/test_console_kernel.py index f86a6cac..7e623b30 100644 --- a/spyder_kernels/console/tests/test_console_kernel.py +++ b/spyder_kernels/console/tests/test_console_kernel.py @@ -1321,10 +1321,12 @@ def test_interrupt(): # not from my request continue break + delta = time.time() - t0 - assert ( - delta < 5 - ), "10 second long call should have been interupted, interrupt signal was likely misshandled" + assert delta < 5, ( + "10 seconds long call should have been interrupted, so the " + "interrupt signal was likely mishandled" + ) def test_enter_debug_after_interruption():