-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Angular 18 #2028
Update Angular 18 #2028
Conversation
e80aee3
to
41a6560
Compare
@oodamien Switch Flo version to 0.14.0 and the build should become green. I was about to push that change myself to this branch but seems like I lost write permission to the repo |
38a210c
to
e7fa073
Compare
Can someone merge this PR please? It's ready to go in my opinion... |
Thanks for the ping @BoykoAlex . We have been busy but will get this on our radar and handle this today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BoykoAlex can you answer the few questions I have from the code changes? I know @oodamien made the changes but I did not review them initially.
Thanks
Signed-off-by: aboyko <[email protected]>
Update Angular 18, Clarity 17, ngrx, luxon Update typescript, eslint, prettier, cypress Resolves #1972 Signed-off-by: aboyko <[email protected]>
Signed-off-by: aboyko <[email protected]>
Signed-off-by: aboyko <[email protected]>
9d3f448
to
8fb0804
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the answers @BoykoAlex . I saw the tests commit as well. 👍🏻
Will get this merged. Thanks for all your help.
It is merged @BoykoAlex . I noticed after the merge the CI was 💚 but dependabot failed on updating some angular libs (here). I have not had a chance to take a peek but if you get a chance to see if it is un/related that would be much appreciated. 🙇🏻 |
Update Angular 18, Clarity 17, ngrx, luxon
Update typescript, eslint, prettier, cypress
Resolves #1972
TODO: Spring-flo update