Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Angular 18 #2028

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Update Angular 18 #2028

merged 4 commits into from
Feb 6, 2025

Conversation

oodamien
Copy link
Contributor

Update Angular 18, Clarity 17, ngrx, luxon
Update typescript, eslint, prettier, cypress
Resolves #1972

TODO: Spring-flo update

@BoykoAlex
Copy link
Collaborator

BoykoAlex commented Jan 17, 2025

@oodamien Switch Flo version to 0.14.0 and the build should become green. I was about to push that change myself to this branch but seems like I lost write permission to the repo

@BoykoAlex BoykoAlex force-pushed the feat/gh-1972 branch 2 times, most recently from 38a210c to e7fa073 Compare January 21, 2025 17:58
@BoykoAlex
Copy link
Collaborator

Can someone merge this PR please? It's ready to go in my opinion...

@onobc
Copy link
Contributor

onobc commented Feb 6, 2025

Thanks for the ping @BoykoAlex . We have been busy but will get this on our radar and handle this today.

Copy link
Contributor

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BoykoAlex can you answer the few questions I have from the code changes? I know @oodamien made the changes but I did not review them initially.

Thanks

ui/src/app/app.module.ts Show resolved Hide resolved
ui/src/app/apps/apps.component.html Show resolved Hide resolved
oodamien and others added 4 commits February 6, 2025 14:16
Signed-off-by: aboyko <[email protected]>
Update Angular 18, Clarity 17, ngrx, luxon
Update typescript, eslint, prettier, cypress
Resolves #1972

Signed-off-by: aboyko <[email protected]>
Signed-off-by: aboyko <[email protected]>
Copy link
Contributor

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the answers @BoykoAlex . I saw the tests commit as well. 👍🏻

Will get this merged. Thanks for all your help.

@onobc onobc merged commit f55b5f0 into main Feb 6, 2025
3 checks passed
@onobc onobc deleted the feat/gh-1972 branch February 6, 2025 20:58
@onobc
Copy link
Contributor

onobc commented Feb 6, 2025

It is merged @BoykoAlex . I noticed after the merge the CI was 💚 but dependabot failed on updating some angular libs (here). I have not had a chance to take a peek but if you get a chance to see if it is un/related that would be much appreciated. 🙇🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Angular 18
3 participants