Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getAllInstances in ConsulDiscoveryClient does not use ACL token for requests #847

Open
ahr-huber opened this issue Feb 28, 2025 · 0 comments · May be fixed by #848
Open

getAllInstances in ConsulDiscoveryClient does not use ACL token for requests #847

ahr-huber opened this issue Feb 28, 2025 · 0 comments · May be fixed by #848
Labels
waiting-for-triage

Comments

@ahr-huber
Copy link

The method ConsulDiscoveryClient.getAllInstances() does not use the ACL token for requests. This means that requests to a Consul instance that requires authentication will fail and the method will return an empty list.
ahr-huber pushed a commit to ahr-huber/spring-cloud-consul that referenced this issue Feb 28, 2025
Fix missing ACL token for getAllInstances
83c2845 
Requests made by ConsulDiscoveryCLient.getAllInstances() were
missing the ACL token.

Fixes spring-cloudgh-847
@ahr-huber ahr-huber linked a pull request Feb 28, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting-for-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing ACL token for getAllInstances ahr-huber/spring-cloud-consul
2 participants
@ahr-huber @spring-cloud-issues