Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump openssl #17

Open
TomA-R opened this issue Dec 27, 2021 · 4 comments · May be fixed by #19
Open

Bump openssl #17

TomA-R opened this issue Dec 27, 2021 · 4 comments · May be fixed by #19

Comments

@TomA-R
Copy link

TomA-R commented Dec 27, 2021

Hey @rwdaigle, any chance we could bump the OpenSSL gem to version 3 (or loosen the dependency)? Thanks!

@TomA-R
Copy link
Author

TomA-R commented Jan 27, 2022

Or maybe @InPermutation (sorry for the direct ping but you seem to be one of the active Ruby devs at Spreedly)

@InPermutation
Copy link

InPermutation commented Jan 27, 2022

@TomA-R can you please write a pull request updating the gemspec to support either 2.x or 3.x? Also, it would be very helpful if you removed Gemfile.lock in the same commit (per https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/ )

The spec.required_ruby_version is also very, very old – would you mind updating it to '>= 2.6.0' and letting me know which version of Ruby you've tested it on?

@machty machty linked a pull request Aug 3, 2022 that will close this issue
@machty
Copy link

machty commented Aug 3, 2022

Opened #19 to address this, incorporating all of the feedback here.

@TomA-R
Copy link
Author

TomA-R commented Aug 27, 2022

Thank you @machty! Hey @InPermutation, any chance that could be reviewed? Thanks a lot in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants