Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only "synced" lyrics provider works. #2302

Open
AdyStudios opened this issue Feb 10, 2025 · 4 comments
Open

Only "synced" lyrics provider works. #2302

AdyStudios opened this issue Feb 10, 2025 · 4 comments
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed

Comments

@AdyStudios
Copy link

AdyStudios commented Feb 10, 2025

System OS

Windows

Python Version

3.10 (CPython)

Install Source

pip / PyPi

Install version / commit hash

4.2.11

Expected Behavior vs Actual Behavior

Expected: when running spotdl with --lyrics genius musixmatch azlyrics at least one of the providers should work. None of them does. I've even tried it with my own genius api. Only synced works, but I prefer the regular providers.

Steps to reproduce - Ensure to include actual links!

Download any song using spotdl [song] --lyrics genius musixmatch azlyrics
The song does have a lyrics on Genius.com: https://genius.com/Warbly-jets-alive-lyrics

Traceback

spotdl download "Warbly Jets - Alive" --lyrics genius musixmatch azlyrics --log-level DEBUG
[19:03:24] DEBUG    MainThread - Downloader settings: {'audio_providers':             downloader.py:129
                    ['youtube-music'], 'lyrics_providers': ['genius', 'musixmatch',
                    'azlyrics'], 'genius_token':
                    'alXXDbPZtK1m2RrZ8I4k2Hn8Ahsd0Gh_o076HYvcdlBvmc0ULL1H8Z8xRlew5qaG
                    ', 'playlist_numbering': False, 'playlist_numbering_only': False,
                    'playlist_retain_track_cover': False, 'scan_for_songs': False,
                    'm3u': None, 'output': '{artists} - {title}.{output-ext}',
                    'overwrite': 'skip', 'search_query': None, 'ffmpeg': 'ffmpeg',
                    'bitrate': None, 'ffmpeg_args': None, 'format': 'mp3',
                    'save_file': None, 'filter_results': True, 'album_type': None,
                    'threads': 4, 'cookie_file': None, 'restrict': None,
                    'print_errors': False, 'sponsor_block': False, 'preload': False,
                    'archive': None, 'load_config': True, 'log_level': 'DEBUG',
                    'simple_tui': False, 'fetch_albums': False, 'id3_separator': '/',
                    'ytm_data': False, 'add_unavailable': False, 'generate_lrc':
                    False, 'force_update_metadata': False, 'only_verified_results':
                    False, 'sync_without_deleting': False, 'max_filename_length':
                    None, 'yt_dlp_args': None, 'detect_formats': None, 'save_errors':
                    None, 'ignore_albums': None, 'proxy': None, 'skip_explicit':
                    False, 'log_format': None, 'redownload': False, 'skip_album_art':
                    False, 'create_skip_file': False, 'respect_skip_file': False,
                    'sync_remove_lrc': False}
[19:03:24] DEBUG    MainThread - FFmpeg path: ffmpeg                                  downloader.py:147
[19:03:24] DEBUG    MainThread - Found 0 known songs                                  downloader.py:182
[19:03:25] DEBUG    MainThread - Archive: 0 urls                                      downloader.py:237
[19:03:25] DEBUG    MainThread - Downloader initialized                               downloader.py:239
[19:03:25] INFO     MainThread - Processing query: Warbly Jets - Alive                    search.py:143
[19:03:26] DEBUG    MainThread - Found 1 songs in 0 lists                                 search.py:361
[19:03:26] DEBUG    MainThread - Downloading 1 songs                                  downloader.py:286
[19:03:28] DEBUG    asyncio_0 - Genius failed to find lyrics for Warbly Jets - Alive  downloader.py:417
[19:03:28] DEBUG    asyncio_0 - MusixMatch failed to find lyrics for Warbly Jets -    downloader.py:417
                    Alive
[19:03:29] DEBUG    asyncio_0 - AzLyrics failed to find lyrics for Warbly Jets -      downloader.py:417
                    Alive
[19:03:29] DEBUG    asyncio_0 - No lyrics found for Warbly Jets - Alive, lyrics       downloader.py:585
                    providers: Genius, MusixMatch, AzLyrics
[19:03:29] DEBUG    asyncio_0 - [51UUbHewbLuTtCGeZDY4Hg] Searching for warbly jets - alive  base.py:168
[19:03:29] DEBUG    asyncio_0 - [51UUbHewbLuTtCGeZDY4Hg] Found 1 results for ISRC           base.py:185
                    US23A1500284
[19:03:29] DEBUG    asyncio_0 - [51UUbHewbLuTtCGeZDY4Hg] Returning only ISRC result         base.py:195
                    https://music.youtube.com/watch?v=ESAYXP2YMB0
[19:03:29] DEBUG    asyncio_0 - Downloading Warbly Jets - Alive using                 downloader.py:690
                    https://music.youtube.com/watch?v=ESAYXP2YMB0
[19:03:35] INFO     asyncio_0 - Downloaded "Warbly Jets - Alive":                     downloader.py:864
                    https://music.youtube.com/watch?v=ESAYXP2YMB0
[19:03:35] DEBUG    MainThread - Took 10 seconds

Other details

The synced option uses a python library called syncedlyrics which itself uses musixmatch, lrclib, netease, megalobiz, genius. That means the other options should be removed, or fixed.

@AdyStudios AdyStudios added the Bug Unexpected problem or unintended behavior that needs to be fixed label Feb 10, 2025
@Lucas-Monsegu
Copy link

It seems that the site structure changed. The scrapper broke. I have made a simple fix that worked locally. I made a quick fix PR if needed

@AdyStudios
Copy link
Author

Thanks! I've added that to my fork

@Aikuros69
Copy link

It seems that the site structure changed. The scrapper broke. I have made a simple fix that worked locally. I made a quick fix PR if needed.

The fix is working, but it embeds incomplete lyrics. I’ve tested it with different songs, and the issue persists. Is anyone else experiencing this?

@AdyStudios
Copy link
Author

Yeah actually, I've just checked, it does cut it off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed
Projects
None yet
Development

No branches or pull requests

3 participants