-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to improve model creation speed #1149
Add options to improve model creation speed #1149
Conversation
These are the results from the benchmark. Results with the name creation and bridges
Results disabling only the name creation
Results disabling the name creation and the bridges
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1149 +/- ##
==========================================
+ Coverage 87.33% 87.35% +0.01%
==========================================
Files 143 143
Lines 4130 4135 +5
==========================================
+ Hits 3607 3612 +5
Misses 523 523 ☔ View full report in Codecov by Sentry. |
@DillonJ, the changes are ready for your review. Please let me know your comments and suggestions. Thanks! |
Changes commented during developers meeting |
Following the performance tips from JuMP docs, this PR implements the following option in the
run_spineopt
function:use_model_names
(default =true
): whether or not to create the model with namesadd_bridges
(default =false
): whether or not bridges from JuMP to the solver should be added to the modelNotes
The
use_model_names
default is equal totrue
, so the users can gain more speed when creating the model by setting this option tofalse
.The
add_bridges
option is set totrue
for the MGA algorithm, since it is necessary to run that feature.Fixes #1148
Checklist before merging