Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli socket path env #5770

Open
kfox1111 opened this issue Jan 11, 2025 · 4 comments · May be fixed by #5776
Open

cli socket path env #5770

kfox1111 opened this issue Jan 11, 2025 · 4 comments · May be fixed by #5776
Labels
priority/backlog Issue is approved and in the backlog

Comments

@kfox1111
Copy link
Contributor

When setting up a more traditional system layout, where your systems socket is under (/var)/run, it would be nice to be able to override the default socket lookup path with an environment variable in spire-agent api and spire-server entry type commands.

@rturner3 rturner3 added the priority/backlog Issue is approved and in the backlog label Jan 14, 2025
@rturner3
Copy link
Collaborator

This sounds reasonable @kfox1111. We would welcome a PR with those changes.

@kfox1111
Copy link
Contributor Author

kfox1111 commented Jan 14, 2025

SPIFFE_ENDPOINT_SOCKET for the spiffe workloadload socket for spire-agent seems like the thing to do.

for the server api, its less clear.

SPIRE_SERVER_ADMIN_SOCKET?

@kfox1111 kfox1111 linked a pull request Jan 15, 2025 that will close this issue
@rturner3
Copy link
Collaborator

SPIRE_SERVER_ADMIN_SOCKET?

SGTM

@kfox1111
Copy link
Contributor Author

After some discussion, we may want to do this in 2 phases. I would think client changes can be made safely without much of a heads up to behavioral changes? While run is a more disruptive change that may need a minor version bump at least as a heads up?

  1. Patch change
    • spire-agent client changes
    • spire-server client changes
  2. Minor change
    • spire-agent run change
    • spire-server run change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/backlog Issue is approved and in the backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants